Pavlushka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ......................................................................
Patch Set 76:
(6 comments)
As the Documentation will be on a different commit.
https://review.coreboot.org/c/coreboot/+/34603/49/Documentation/mainboard/in... File Documentation/mainboard/index.md:
https://review.coreboot.org/c/coreboot/+/34603/49/Documentation/mainboard/in... PS49, Line 11: - [H110M-E/M.2](asus/h110m-e_m2.md)
Just don't forget to add it. Leaving this comment unresolved as a reminder.
Done
https://review.coreboot.org/c/coreboot/+/34603/54/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/54/src/mainboard/asus/h110m-e... PS54, Line 182: \
not needed
Done
https://review.coreboot.org/c/coreboot/+/34603/54/src/mainboard/asus/h110m-e... PS54, Line 183: \
same
Done
https://review.coreboot.org/c/coreboot/+/34603/54/src/mainboard/asus/h110m-e... PS54, Line 184: \
same ... […]
Done
https://review.coreboot.org/c/coreboot/+/34603/70/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/34603/70/src/mainboard/asus/h110m-e... PS70, Line 22: #define _PAD_CFG_STRUCT(val, config0, config1)
lolwhat? :D :P […]
Done
https://review.coreboot.org/c/coreboot/+/34603/69/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/34603/69/src/mainboard/asus/h110m-e... PS69, Line 22: #define H110_PAD_DW0_DW1_CFG(val, config0, config1) \
see https://review.coreboot.org/c/coreboot/+/34603/70/src/mainboard/asus/h110m-e.... […]
Done