Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34791 )
Change subject: soc/intel/cannonlake: Speed up postcar loading using intermediate caching
......................................................................
Patch Set 11:
Yes, this was written with tongue in the cheek. Give us native raminit and source, and we'll likely throw out any UEFI and instantly take away 50+ ms from cold boots. Unless the figures against a solution with POSTCAR_STAGE=y show a much more significant improvement (4 ms of 830ms is <0.5 %) I see no value in the approach of skipping the separate POSTCAR_STAGE.
Its not only size reduction as i have pointed out in past gerrit update. Coreboot should have flexible stage requirement, where one should be able to pick or drop a stage. if could see the note from Aaron, why he has introduced postcar and we should be able to achieve the say in ramstage as well without introducing a new stage if we wish.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ba63887acb5c4bdeaf3e21c24fb0e631362962c
Gerrit-Change-Number: 34791
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 20 Aug 2019 02:23:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment