Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37016 )
Change subject: security/intel/txt: Add Intel TXT support ......................................................................
Patch Set 10:
(6 comments)
https://review.coreboot.org/c/coreboot/+/37016/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37016/7//COMMIT_MSG@24 PS7, Line 24: Tested on OCP Wedge100s and Facebook Watson
No not yet but everything pre-cbnt should work
Ack
https://review.coreboot.org/c/coreboot/+/37016/8/src/security/intel/txt/comm... File src/security/intel/txt/common.c:
https://review.coreboot.org/c/coreboot/+/37016/8/src/security/intel/txt/comm... PS8, Line 234: if (acm_len % 64 != 0) {
Don't forget the negation? […]
Done
https://review.coreboot.org/c/coreboot/+/37016/8/src/security/intel/txt/comm... PS8, Line 244: if ((uintptr_t)acm_data & ((1UL << log2_ceil(acm_len)) - 1)) {
Hrm... […]
Done
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/gets... File src/security/intel/txt/getsec_enteraccs.S:
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/gets... PS7, Line 66:
double empty line
Done
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/gets... PS7, Line 118: 1
Oh, the macros use these labels? I'd give them more descriptive names so that it's easier to underst […]
Done
https://review.coreboot.org/c/coreboot/+/37016/7/src/security/intel/txt/gets... PS7, Line 191: 1:
looks unused
Done