[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/rex/var/karis: Modify SSD settings

[Matt DeVillier (Code Review)]

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77006?usp=email )

Change subject: mb/google/rex/var/karis: Modify SSD settings
......................................................................

mb/google/rex/var/karis: Modify SSD settings

Follow schematic, modify SSD related settings.

BUG=b:294155897, b:289880020
TEST=emerge-rex coreboot

Change-Id: Ie9c228ed7ccc83afaa8365f89c1d5cdedc4f0c8c
Signed-off-by: Tyler Wang 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77006
Reviewed-by: Eric Lai 
Reviewed-by: Subrata Banik 
Reviewed-by: Kapil Porwal 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/rex/variants/karis/gpio.c
M src/mainboard/google/rex/variants/karis/overridetree.cb
2 files changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Eric Lai: Looks good to me, approved
  Kapil Porwal: Looks good to me, approved
  Subrata Banik: Looks good to me, approved
  build bot (Jenkins): Verified

diff --git a/src/mainboard/google/rex/variants/karis/gpio.c b/src/mainboard/google/rex/variants/karis/gpio.c
index 123fb36..4602983 100644
--- a/src/mainboard/google/rex/variants/karis/gpio.c
+++ b/src/mainboard/google/rex/variants/karis/gpio.c
@@ -119,8 +119,8 @@
    PAD_CFG_NF(GPP_C11, NONE, DEEP, NF1),
    /* GPP_C12 : [] ==> WWAN_CLKREQ_ODL */
    PAD_CFG_NF(GPP_C12, NONE, DEEP, NF1),
-	/* GPP_C13 : [] ==> SSD_CLKREQ_ODL */
-	PAD_CFG_NF(GPP_C13, NONE, DEEP, NF1),
+	/* GPP_C13 : Not connected */
+	PAD_NC(GPP_C13, NONE),
    /* GPP_C15 : [] ==> WWAN_DPR_SAR_ODL */
    PAD_CFG_GPO(GPP_C15, 1, DEEP),
    /* GPP_C16 : [] ==> USB_C0_LSX_TX */
@@ -180,8 +180,8 @@
    PAD_NC(GPP_D18, NONE),
    /* GPP_D19 : [] ==> EC_SOC_REC_SWITCH_ODL */
    PAD_CFG_GPI_LOCK(GPP_D19, NONE, LOCK_CONFIG),
-	/* GPP_D20 : net NC is not present in the given design */
-	PAD_NC(GPP_D20, NONE),
+	/* GPP_D20 : [] ==> SSD_CLKREQ_ODL */
+	PAD_CFG_NF(GPP_D20, NONE, DEEP, NF1),
    /* GPP_D21 : [] ==> WLAN_CLKREQ_ODLl */
    PAD_CFG_NF(GPP_D21, NONE, DEEP, NF2),
    /* GPP_D22 : net NC is not present in the given design */
diff --git a/src/mainboard/google/rex/variants/karis/overridetree.cb b/src/mainboard/google/rex/variants/karis/overridetree.cb
index 793a46d..080e228 100644
--- a/src/mainboard/google/rex/variants/karis/overridetree.cb
+++ b/src/mainboard/google/rex/variants/karis/overridetree.cb
@@ -295,14 +295,14 @@
    			device generic 0 alias dptf_policy on end
    		end
    	end
-		device ref pcie_rp9 on
-			# Enable SSD Card PCIE 9 using clk 4
-			register "pcie_rp[PCH_RP(9)]" = "{
-				.clk_src = 4,
-				.clk_req = 4,
+		device ref pcie_rp10 on
+			# Enable SSD Card PCIE 10 using clk 8
+			register "pcie_rp[PCIE_RP(10)]" = "{
+				.clk_src = 8,
+				.clk_req = 8,
    			.flags = PCIE_RP_LTR | PCIE_RP_AER,
    		}"
-		end	#PCIE9 SSD card
+		end # PCIE10 SSD card
    	device ref ish on
    		probe ISH ISH_ENABLE
    		chip drivers/intel/ish