Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37327 )
Change subject: arch/x86/car.ld: Drop CAR_GLOBAL region
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37327/1/src/arch/x86/car.ld
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/37327/1/src/arch/x86/car.ld@a109
PS1, Line 109: #if CONFIG(CAR_GLOBAL_MIGRATION)
Do we want if !ENV_STAGE_HAS_BSS_SECTION here?
At the moment all stages have .bss so this would not make much sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37327
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id66fd0528987fb3e464d400cf9ccac98752fb8f5
Gerrit-Change-Number: 37327
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 30 Nov 2019 12:48:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment