Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40030 )
Change subject: ec/google/chromeec: New host command EC_CMD_GET_KEYBD_TOP_ROW_LAYOUT ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40030/1/src/ec/google/chromeec/ec_c... File src/ec/google/chromeec/ec_commands.h:
PS1:
There are quite a lot of differences in EC repository's [cros/master:include/ec_commands. […]
src/platform/ec master branch should be the place where changes to ec_commands.h to take place
https://review.coreboot.org/c/coreboot/+/40030/1/src/ec/google/chromeec/ec_c... PS1, Line 2976: 0x002E I think we are actually on on 0x0130 for the next available host command
https://review.coreboot.org/c/coreboot/+/40030/1/src/ec/google/chromeec/ec_c... PS1, Line 3039: can_send_function_keys
Let make it an enum instead […]
It could be like a function lock, the default press is function and then the FN + key is the normal chromos key (like back). We should account for that use case too.