build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35402/13/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse_bp.c:
https://review.coreboot.org/c/coreboot/+/35402/13/src/soc/intel/common/block... PS13, Line 205: printk(BIOS_ERR, "Could not set CSE's next boot partition to %d\n", next_bp + 1); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35402/13/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/13/src/soc/intel/common/block... PS13, Line 175: * Boot Partition Info Flag Minimum Recovery Mode Enabled code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35402/13/src/soc/intel/common/block... PS13, Line 175: * Boot Partition Info Flag Minimum Recovery Mode Enabled please, no space before tabs
https://review.coreboot.org/c/coreboot/+/35402/13/src/soc/intel/common/block... PS13, Line 234: uint8_t cse_get_bp_entry_version(uint8_t boot_partition, struct partition_fw_version *fw_version); line over 96 characters