David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32533 )
Change subject: [wip]watchdog: Use common watchdog_off function
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32533/4/src/southbridge/intel/common/watchdo...
File src/southbridge/intel/common/watchdog.c:
https://review.coreboot.org/#/c/32533/4/src/southbridge/intel/common/watchdo...
PS4, Line 55: write_pmbase16(TCOBASE + TCO2_STATUS, (1 << 2));
Some of the files you remove use:
outw(0x0002, abase + 0x66);
This writes 0x2, does your code write 0x4?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I704780b6ae7238560dcb72fc027addc1089e0674
Gerrit-Change-Number: 32533
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Guckian
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 01 May 2019 17:00:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment