[coreboot-gerrit] Change in coreboot[master]: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 )

Change subject: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard
......................................................................

Patch Set 17:

(1 comment)

https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... 
File src/mainboard/libretrend/lt1000/bootblock.c:

https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... 
PS15, Line 14: #define SERIAL1_DEV	PNP_DEV(0x2e, IT8786E_SP1)
> It’d be great if you added that as comment.

Ohh my bad...

"IT8786E has 6 COM ports, COM1/3/5 have default IO base 0x3f8 and COM2/4/6 have 0x2f8."

So they do not share 0x3f8 only. There is an extensive comment below. See line 29