Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38832 )
Change subject: Doc/ifdtool: Explain how to modify IFD regions ......................................................................
Patch Set 3:
(8 comments)
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38832/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38832/2//COMMIT_MSG@7 PS2, Line 7: Documentation/ifdtool: modify IFD regions
Doc/ifdtool: Explain how to modify IFD regions
Done
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... File Documentation/ifdtool/layout.md:
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 37: It is possible to adjust the IFD regions on a firmware image or on a
Please reflow the added text so that the lines are more or less of the same length as the existing o […]
Done
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 37: It is possible to adjust the IFD regions on a firmware image or on a
Please reflow the added text so that the lines are more or less of the same length as the existing o […]
Done
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 71: boundry
boundary
Done
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 71: allign
align
Done
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 71: best practice
nit: Not only best practice, the hardware can't handle any finer granularity
you're right! I will mention it.
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 93: Instead of using the the ifdtool directly, it is possible to define a flashrom layout file in the
line length limit
Done
https://review.coreboot.org/c/coreboot/+/38832/2/Documentation/ifdtool/layou... PS2, Line 93: the the
None of these "the" is needed
Done