EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39865 )
Change subject: soc/intel/tigerlake: Reorganize memory initialization support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39865/2/src/soc/intel/tigerlake/mem...
File src/soc/intel/tigerlake/meminit_tgl.c:
https://review.coreboot.org/c/coreboot/+/39865/2/src/soc/intel/tigerlake/mem...
PS2, Line 22: static uint8_t get_dimm_cfg(uintptr_t dimm0, uintptr_t dimm1)
Disabling of CH1 is not a problem. It is already supported. […]
I will give a shot. Because windows can do the same thing and we did it in CNL. Like SODIMM, we can choice just use CH0 or CH1, right? User can choice any slot to plug the memory.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib625f2ab30a6e1362a310d9abb3f2051f85c3013
Gerrit-Change-Number: 39865
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 27 Mar 2020 18:02:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment