build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46661 )
Change subject: sc7180: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot. ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46661/1/src/soc/qualcomm/sc7180/car... File src/soc/qualcomm/sc7180/carve_out.c:
https://review.coreboot.org/c/coreboot/+/46661/1/src/soc/qualcomm/sc7180/car... PS1, Line 6: #define MODEM_ID_ADDR (void *)0x146ABC00 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46661/1/src/soc/qualcomm/sc7180/car... PS1, Line 9: #define MODEM_ID_WIFI_END (void *)0x88000000 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46661/1/src/soc/qualcomm/sc7180/car... PS1, Line 14: switch (modem_id) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/46661/1/src/soc/qualcomm/sc7180/soc... File src/soc/qualcomm/sc7180/soc.c:
https://review.coreboot.org/c/coreboot/+/46661/1/src/soc/qualcomm/sc7180/soc... PS1, Line 21: if (soc_modem_carve_out(&start, &end)) { braces {} are not necessary for single statement blocks