Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32339 )
Change subject: mediatek/mt8183: Enable RTC eosc calibration feature to save power
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG@9
PS1, Line 9: shutdown
In atf code, RTC will switch clock source from dcxo to eosc before real shutdown. […]
Is there a good reason why this is handled in coreboot/Arm TF respectively? Why can't you just do it in the kernel instead? Generally, functionality shouldn't be implemented in firmware unless there's a good reason why it can't be done by the OS, and having a slightly more accurate RTC for the one second it takes us to load the kernel doesn't really seem like a good enough reason.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32339
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee21e7611df8959cbbc63b6e6655cfb462147748
Gerrit-Change-Number: 32339
Gerrit-PatchSet: 2
Gerrit-Owner: Ran Bi
ran.bi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Ran Bi
ran.bi@mediatek.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Apr 2019 21:23:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ran Bi
ran.bi@mediatek.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment