Attention is currently required from: Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop blob loading changes ......................................................................
Patch Set 3:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/a98f4075_820f5f74 PS3, Line 11: bool aop_fw_entry; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/996f199b_3ddfe853 PS3, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/0b47b92b_b953dd9e PS3, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/6e44b01c_2f370633 PS3, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/c3e0d008_a2f94d8b PS3, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/6d7fda0d_f9683af0 PS3, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/d9f33e8a_eb6d20d9 PS3, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/83d316cf_206309fb PS3, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/1f1533fa_41cc47f9 PS3, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/0cdc5266_e41a0f01 PS3, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/9834c132_468ca203 PS3, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/e9b84150_338754f2 PS3, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/00f550e9_ba226a38 PS3, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/6e86e966_7de66523 PS3, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/cd730539_fdffe935 PS3, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/15a1686c_046be9a7 PS3, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/a14dc64a_12266331 PS3, Line 23: clock_reset_aop(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/9ecccaaf_198f1255 PS3, Line 23: clock_reset_aop(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/a96f3cc9_a0033b17 PS3, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/51f340d2_c9b83c27 PS3, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/b17f56c8_32422edf PS3, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/30a6ad6c_f2ba99dd PS3, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49767/comment/726e3a6c_87aa481d PS3, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/d9a3da88_a6887334 PS3, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/343272e1_81e131df PS3, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49767/comment/7d68b848_efa23704 PS3, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line