Attention is currently required from: Mario Scheithauer, Arthur Heymans, Werner Zeh.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69611 )
Change subject: device/mdio: Provide helper functions for read and write
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/device/mdio.c:
https://review.coreboot.org/c/coreboot/+/69611/comment/309cfe2e_e7501d21
PS4, Line 27: 0
Do you know if the MDIO spec specifies a default value when attempting to read from a non-existing […]
There's the error print in `dev_get_mdio_ops()` which should suffice.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69611
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I293d93435d27269a071b4b9b94a1b55307c575a7
Gerrit-Change-Number: 69611
Gerrit-PatchSet: 5
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 22 Nov 2022 12:31:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment