Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45756 )
Change subject: mb/google/zork: config eMMC RST GPIO to NC
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45756/3/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/45756/3/src/mainboard/google/zork/v...
PS3, Line 88: *
It would be helpful to have a comment here indicating why this pad is being configured as NC (in case someone comes here looking for the pad).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45756
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9feb826eec8a8cdad5e2bd7efcbb1dcf96185dfd
Gerrit-Change-Number: 45756
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Sep 2020 02:28:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment