Matthew Garrett has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32530 )
Change subject: drivers/intel/fsp2_0: Fix fsp post-init validation
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/32530/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32530/4//COMMIT_MSG@7
PS4, Line 7: Fix fsp post-init validation
please add a prefix
Done
https://review.coreboot.org/#/c/32530/4//COMMIT_MSG@9
PS4, Line 9: Part of this checks whether tolum_base and cbmem_top are the same - however,
true, cbmem is initilaized in do_fsp_post_memory_init()
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32530
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib89e0513bdc35c3751a9d4c2a2789a2836046789
Gerrit-Change-Number: 32530
Gerrit-PatchSet: 7
Gerrit-Owner: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 02 May 2019 20:54:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment