Attention is currently required from: Shelley Chen, Ravi kumar, Julius Werner, mturney mturney.
Vinod Polimera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52663 )
Change subject: sc7180: Add backlight support for sn65dsi86bridge
......................................................................
Patch Set 4:
(2 comments)
File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/52663/comment/a2421419_dd9e754e
PS1, Line 446: sn65dsi86_bridge_dpcd_request(bus, chip, DP_BACKLIGHT_MODE_SET, 1, DPCD_READ, &val);
Any reason these all need to be read-modify-write? All the other bits are power-on 0 and I don't see […]
Done
https://review.coreboot.org/c/coreboot/+/52663/comment/2fa0299c_42af6652
PS1, Line 458: 2
While I'm sure it works that way, the whole "write two bytes because we know the LSB register comes […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52663
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie700080f1feabe2d3397c38088a64cff27bfbe55
Gerrit-Change-Number: 52663
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Fri, 07 May 2021 08:14:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment