Attention is currently required from: Sean Rhodes. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 15:
(363 comments)
File util/coreboot-configurator/src/Documentation.txt:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2196be6c_e9a35fb8 PS15, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'?
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/54a95849_ae5f970b PS15, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b0aa08eb_c6d1ddf8 PS15, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/09b9dae0_b659da90 PS15, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6dd139f5_3f433f13 PS15, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c26562b9_c3433966 PS15, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1a77f037_733f3c79 PS15, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6269091f_738feb0e PS15, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/60ebdfe9_57c933de PS15, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c39444cd_7c68511f PS15, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3ab06318_95f8b4c0 PS15, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/40dc98e9_f76f0c98 PS15, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6d00809f_26f1d3e9 PS15, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1e4645d4_4f902998 PS15, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8141d901_4168ba01 PS15, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/af209181_a474e5e5 PS15, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7c4e939f_abfbb1f3 PS15, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0e2ae25d_2e0584ab PS15, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/14337061_660ab78b PS15, Line 37: void showEvent(QShowEvent *ev); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/08bfe020_f481a4c0 PS15, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8648e4f7_32aceafb PS15, Line 38: void closeEvent(QCloseEvent *ev); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/27423284_c298b741 PS15, Line 42: void closeWindow(int result); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/43bc1583_884dd13f PS15, Line 43: void saveAndClose(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/25ff589d_ea771ae0 PS15, Line 46: void getSettings(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dc8a99b3_64b0933f PS15, Line 47: void getFromFile(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c292aa23_d4b1d832 PS15, Line 48: void displaySettings(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/24cbcf3f_6234bc61 PS15, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b45c3298_2e2f20a1 PS15, Line 51: void writeSettings(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/edd63bf4_0401a6f9 PS15, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f5aa5f3a_5d50361b PS15, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/57cb6f09_0ed03de8 PS15, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6e6b356a_01d1c9e9 PS15, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4efa9bc1_45630d56 PS15, Line 59: QString m_fileName; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ac988067_afbc2839 PS15, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6082d656_c5cc3493 PS15, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/da509137_b4bd0881 PS15, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/be3ed5b2_f9c469d1 PS15, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dcd20a0d_197cf259 PS15, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3514a48c_e3804585 PS15, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/573d7bb7_52155488 PS15, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/23c8470a_4ecb2d59 PS15, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/076be2e6_d84b6e73 PS15, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c862f95f_216858b1 PS15, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c6120010_57883ec1 PS15, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6ef99821_0097bef3 PS15, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c0576ac1_79ad0262 PS15, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9a753df1_f1e2d0e9 PS15, Line 30: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d763c858_11f162d9 PS15, Line 30: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1c6cbd83_2e0084ee PS15, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2a89b211_062c135c PS15, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/167e3009_f78c6123 PS15, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/006fb363_d6d78051 PS15, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/de257d0b_95f134a8 PS15, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8a2c6bf8_0ddbe329 PS15, Line 34: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ca90fb47_3cff7d7d PS15, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b7fb9cd0_cf7eeb5c PS15, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0c0476fc_b2c29d5e PS15, Line 36: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4f3d8e94_a34ccaec PS15, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/982529e3_c9bf18b1 PS15, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7b93d18d_3219c270 PS15, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b2a96365_f83d7e0a PS15, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/74190db2_16d95900 PS15, Line 39: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/517d2b8d_8b470ddc PS15, Line 40: if (!node.IsScalar()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/86b1d796_2ce59a3b PS15, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8c7b690c_d5eb6c96 PS15, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/685e1bbc_b1dd5bf4 PS15, Line 41: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/69c4829b_e54754cf PS15, Line 41: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f29148d5_90111283 PS15, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d73ec38c_8d0defb5 PS15, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1f803ffa_d646c11f PS15, Line 43: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3f11bc92_d69385aa PS15, Line 43: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2da21889_8e1791ab PS15, Line 44: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9549c9b7_532c9209 PS15, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a61603d0_78a5346b PS15, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3892276a_8322f9c2 PS15, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d6409477_1ec5e550 PS15, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9e8e07df_1df53951 PS15, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b1a7b7ca_e354e82e PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/282fc9ec_9451e711 PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6b896cec_f243cf9b PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/322c0fe0_a7185609 PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8cac5796_3d617e7d PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4dfc820e_42f1a544 PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6a0eebd0_38da6300 PS15, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/000d3a51_7f8e455c PS15, Line 52: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6c4a156f_8a13f736 PS15, Line 53: Node node(NodeType::Map); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/275d43a1_a20deacd PS15, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3ba0a8c4_a3b7042f PS15, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/54a302aa_99a408c3 PS15, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e0c306ce_ab82148e PS15, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/fec75194_1a734700 PS15, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/36eed318_7a4a2536 PS15, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/37e338af_add22a7c PS15, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c8a1a4bb_37ae1e4f PS15, Line 56: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/14e7da6c_3095cb75 PS15, Line 56: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b2719ca6_10cd8ed5 PS15, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/259bbe6d_15159800 PS15, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c0df2dfa_41fe938f PS15, Line 58: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7444fe32_5f11d336 PS15, Line 58: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/290c289b_4cc18660 PS15, Line 59: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a57fe4d2_5e31339c PS15, Line 59: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/42ff4c28_7ef2f9ee PS15, Line 60: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7e25b423_d59e8ab3 PS15, Line 60: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/deeeea56_2d52bbe7 PS15, Line 61: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f9014736_a72679d1 PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2b609342_629d3000 PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/883d63d5_287f69ba PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/428aed91_cfa7d555 PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8293932f_4853b01f PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bd1e2ba0_7b039b1d PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/34749384_f3aa6348 PS15, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9921a8a7_5e93b0f7 PS15, Line 64: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/46c669be_c66d34ac PS15, Line 65: if (!node.IsMap()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/29e03c2c_420f75d4 PS15, Line 65: if (!node.IsMap()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/830fedfa_da9f8f3a PS15, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/efaaff30_a26cbfb9 PS15, Line 66: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7da19d97_2d1d1760 PS15, Line 66: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8f60d95e_2b512724 PS15, Line 68: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/27f5e248_633657dd PS15, Line 68: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/fe99b0b1_652ccac6 PS15, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3a4f8f36_5b9f00d0 PS15, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a7b63769_9243c96e PS15, Line 70: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/08b14660_ef6ba293 PS15, Line 70: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/76a198f2_6442ced7 PS15, Line 70: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/38b7f629_db82e603 PS15, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/67f1c968_2db52afc PS15, Line 71: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/773f086b_aac5f823 PS15, Line 71: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0b6ab901_d461f0bc PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f03854a5_cc639542 PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/245766c4_155ca1af PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/cac23fa9_fb064958 PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/49761fed_1a68a541 PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/247197fd_ffdc0d39 PS15, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0865192c_88c0f8e0 PS15, Line 73: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f934ab92_246c35c3 PS15, Line 73: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8e7328b2_2cfb0857 PS15, Line 74: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/99746b4d_33767b8b PS15, Line 74: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0a95b36b_780ff192 PS15, Line 75: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/336f8386_c5637cfd PS15, Line 75: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5e0f7fdd_f65a3bdd PS15, Line 76: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/86ecc8d8_d6e7b119 PS15, Line 80: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/683df71b_e8b48050 PS15, Line 80: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/08801d71_8098191b PS15, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1f22d21c_200505b6 PS15, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/685a24c5_5b8e8b44 PS15, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ce67ae8b_d863c394 PS15, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7b614f96_5e7c324d PS15, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8dd126ee_69d5a29d PS15, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/71cf83e5_2685e44d PS15, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a7318344_a4987084 PS15, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7599a15d_c17781b5 PS15, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f847de63_ab6a1bb7 PS15, Line 84: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/183ed5c2_c833d216 PS15, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b447c708_837122c7 PS15, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/be93dc32_50c5ab35 PS15, Line 86: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d28e11f1_64bbdb57 PS15, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a3eb7d8d_e66681d8 PS15, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/caa9c28f_8946c69e PS15, Line 87: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/aefc3582_e652994f PS15, Line 87: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8b7792c1_ba12ddde PS15, Line 88: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/20360081_f58da623 PS15, Line 88: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9df3c0ae_65d2efde PS15, Line 89: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b55706ef_d6f9a620 PS15, Line 89: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0d29ca49_3210ebcf PS15, Line 90: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6a532396_de5c188a PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9092c5e6_c7df19d8 PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ba779e0c_b82fd6ae PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/52eeb0e4_43596081 PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e0832919_aa4c3583 PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/80ebb5bb_183c9a3b PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/48ac08dc_0e4c7e4d PS15, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8e582f0b_b3e01137 PS15, Line 93: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a121bbf2_b649311c PS15, Line 94: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3afa98e1_f1ab943c PS15, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8f1171b0_79bd2c25 PS15, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4b882496_8e74c80d PS15, Line 95: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5029bf87_8388f094 PS15, Line 95: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dd673448_cfb69642 PS15, Line 97: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/cb9bd6f1_67dbca83 PS15, Line 97: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6ab6dae8_558d5547 PS15, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9e6ce7e5_40baa0c5 PS15, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5a9fab4d_35f0d012 PS15, Line 99: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ea6d32bb_8f96a520 PS15, Line 99: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/00c0141d_ec5c22c9 PS15, Line 99: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8824c695_c01be871 PS15, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6e86702a_a3b407e4 PS15, Line 100: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5da1714d_cea709e8 PS15, Line 100: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3892a684_fe8e6d26 PS15, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b23d8acc_2da45d29 PS15, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a4383bc3_95069553 PS15, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4c7e00b2_a9b2c6d0 PS15, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7bc4cad5_1efc7fd8 PS15, Line 102: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bb6a7b43_de03dce4 PS15, Line 102: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8af201f6_93d66afb PS15, Line 103: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/665a27e6_970048a7 PS15, Line 103: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2fa2cfba_34b68878 PS15, Line 104: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/55738c1b_f62a19a3 PS15, Line 104: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0299963c_2c4cef62 PS15, Line 105: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3d641b0d_54fef693 PS15, Line 109: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/01bf568b_62ecda6c PS15, Line 109: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7816d914_ccc8181d PS15, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bc8630f3_f0ae0510 PS15, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ca081a72_11dfea73 PS15, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2d1c8b47_99ca0bf0 PS15, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c28cd8aa_fac4a3f9 PS15, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b37f3c8a_45c4c7d9 PS15, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/37134ac4_a95858c1 PS15, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ad7bbcc9_2ac739b9 PS15, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1d962eac_a3cf7197 PS15, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/666fe8cc_3d4dc6a5 PS15, Line 113: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c7b74ce0_e128db66 PS15, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/cecb5f57_384d0afb PS15, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/054bbe6b_af2c4223 PS15, Line 115: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/78777388_f8c9ddef PS15, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/84e4bb01_b68488c9 PS15, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5538378c_320f385f PS15, Line 116: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a3dfe446_259f2a8f PS15, Line 116: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0edb5dce_60710ff5 PS15, Line 117: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b8d51328_3f825430 PS15, Line 117: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ee40ebe2_0aba8e9f PS15, Line 118: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6b108508_081ae9fe PS15, Line 118: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bba1d168_a11f85b9 PS15, Line 119: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/46e37805_f2eb30eb PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f5f43581_a152db2d PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e23cc069_9f16525a PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/11c01509_a5c39f15 PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1e4078fe_87e7f505 PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/eb49b493_4c93147b PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4d5797ed_3cf0d032 PS15, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/da670125_fa5057ac PS15, Line 122: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b79407b3_66e953cb PS15, Line 123: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/eb2ca8fd_5b4796d9 PS15, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/de6f9d86_38b54b23 PS15, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/072094bd_3ae0a69f PS15, Line 124: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/fe580e30_2724edf6 PS15, Line 124: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a7b33a4e_e568ee9f PS15, Line 126: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ce518edb_2e3e8e9b PS15, Line 126: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/14e27337_139d88b9 PS15, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/70d56443_2e00d66b PS15, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3e2058f4_25f7ce44 PS15, Line 128: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7725735d_a7fd7a57 PS15, Line 128: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0e8984f2_bf1abee2 PS15, Line 128: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a9afcd35_f8f4cb93 PS15, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/42b5f569_84b30279 PS15, Line 129: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/68b4670d_0a062e1f PS15, Line 129: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7cefc16d_aaac7510 PS15, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/df802d9d_57b57e6c PS15, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f7639210_501a5853 PS15, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bcfb4e72_268c0bc1 PS15, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/df8e6757_616a7883 PS15, Line 131: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/977e8311_a5759e39 PS15, Line 131: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4fc43040_3ad32e35 PS15, Line 132: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ad5d613a_34f2f4b8 PS15, Line 132: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f835a466_78f1af41 PS15, Line 133: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a0e950b5_f10b2751 PS15, Line 133: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e88670ec_e3a16e89 PS15, Line 134: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/02082603_618cae1e PS15, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9a0b5df0_b1f5e506 PS15, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8d4538c2_87f05b2e PS15, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2d404b7b_6d661b00 PS15, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/654831c3_ccdb1e79 PS15, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a2f37be0_216da8cc PS15, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4a63a8ec_2ad2362b PS15, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7d7319be_61d9e8aa PS15, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b5cbe513_d5c2771d PS15, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ad93ccab_3b3bac90 PS15, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/968301ff_8595de0f PS15, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1b7b95c0_855a7396 PS15, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9521d5fc_56fdaded PS15, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/24506bd5_5976d124 PS15, Line 142: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d8d56e4e_89a793b4 PS15, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f7be0bf4_dfb31af6 PS15, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d4793f75_e5d2cd64 PS15, Line 144: node.push_back(rhs.first); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ed48b98c_6beeab6d PS15, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a2bdc7da_c70b9050 PS15, Line 145: node.push_back(rhs.second); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/cb5d0a4c_e6e0d3e8 PS15, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6abd9b51_48f8772e PS15, Line 146: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a610d9c0_6257a4ef PS15, Line 146: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f66240fb_c322f0e9 PS15, Line 147: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/6659fb04_fd839437 PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5aa3d7bb_52503d2f PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d347e2af_88de2d99 PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ff854b03_49cdd4a9 PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/298dd8ab_0936735c PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d550f09c_0d88fe01 PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/cb032012_7ea5f73a PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2bfc8abe_5a03657e PS15, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ae654ff2_62c762e4 PS15, Line 150: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b16af49d_bbd97f44 PS15, Line 151: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5de0d6ee_2fac3a6c PS15, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9e80d1a7_c89eb2ad PS15, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5bd313c4_c536b1b3 PS15, Line 152: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f73d8a83_ae449d3a PS15, Line 152: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1dfe9b4a_e7ddc095 PS15, Line 153: if (node.size() != 2) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b6571ed6_d069e18b PS15, Line 153: if (node.size() != 2) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/788d10ae_ff10ba8c PS15, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c0877b3b_5c049efb PS15, Line 154: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/392f25a6_ea49fbd3 PS15, Line 154: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f12d701f_c00010c0 PS15, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1504576a_1f48c15a PS15, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8abd16bb_eef119b6 PS15, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8bc3db73_71f23313 PS15, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/df6ead3a_9ccb672d PS15, Line 157: rhs.second = node[1].as<U>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/68e611bf_bf02d4b6 PS15, Line 157: rhs.second = node[1].as<U>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4299bebd_ba929cd5 PS15, Line 157: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7008e4a6_6379f9a3 PS15, Line 157: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/69eee861_609410fa PS15, Line 158: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/11e99caa_6b914e7c PS15, Line 158: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e9ce2a8f_50be7270 PS15, Line 159: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/737e2413_dd18e25c PS15, Line 163: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0204585d_07833baa PS15, Line 163: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8acb03a4_244c8ee5 PS15, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/77190b76_2c125c78 PS15, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0f7c2907_45382dfd PS15, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a5e71ad8_0be350f5 PS15, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/bd4b69c0_27760a65 PS15, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/ca3b841f_f8a2b10c PS15, Line 167: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/eb3a93a3_0c00c7d3 PS15, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a7dda37c_1c42faa2 PS15, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/56a89e88_99d0d76f PS15, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/514d318b_7b8bebff PS15, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/370fd439_d9747137 PS15, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/483d8cff_cd35b233 PS15, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a7025c23_5cc45bed PS15, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f7a6719f_fbb88b92 PS15, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3aa19548_ec2c1628 PS15, Line 170: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e6a7e2bf_ca071ada PS15, Line 170: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/4e12909f_618795ca PS15, Line 171: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e460918e_90f5be3a PS15, Line 171: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/efa477da_a7b17361 PS15, Line 172: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f968f543_8f28ea69 PS15, Line 172: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e19376bd_7901436d PS15, Line 173: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/86275e11_0585fb92 PS15, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/c584097b_dad765ab PS15, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/3358033b_7c6fcc49 PS15, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/2fc30a3e_e6666058 PS15, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dc937f50_a9a35c21 PS15, Line 176: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/780e0c76_e68c30a8 PS15, Line 177: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/7c58d1d3_e3ef3826 PS15, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/61a39306_d51a33af PS15, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f87f51f7_f8f130b3 PS15, Line 178: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0fe0fbb6_9022ce7f PS15, Line 178: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/98827d9e_953050a2 PS15, Line 180: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/9145b295_52bf385f PS15, Line 180: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/64db88b4_7c983930 PS15, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/e2e1c541_47c7e271 PS15, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/24d4d5d2_62328a2f PS15, Line 182: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/96a475c6_828afaa5 PS15, Line 182: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d235898a_765499bc PS15, Line 182: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/278553a6_831ab619 PS15, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/8ef98548_e4f37957 PS15, Line 183: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/a751285a_611f8bea PS15, Line 183: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dcfbc6c9_54486156 PS15, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d5c31936_ccdfcfba PS15, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/dc063eeb_b462407e PS15, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/d6ab798c_d715ec9b PS15, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/f5550870_260f70a6 PS15, Line 185: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0ba1d2dc_03bc246c PS15, Line 185: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/1ec95bac_08af7005 PS15, Line 186: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/b77e184f_5eccf27d PS15, Line 186: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/decea6fb_5c62c110 PS15, Line 187: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/5e849eea_f676adf5 PS15, Line 187: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132310): https://review.coreboot.org/c/coreboot/+/58854/comment/0a56d607_3591cf2b PS15, Line 188: } please, no spaces at the start of a line