Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35367 )
Change subject: mb/ocp/monolake: Add a GPIO table for initializing configuration
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35367/1/src/mainboard/ocp/monolake/...
File src/mainboard/ocp/monolake/gpio.h:
https://review.coreboot.org/c/coreboot/+/35367/1/src/mainboard/ocp/monolake/...
PS1, Line 50: 28
in follow up patch, could you please provide string literals for these numbers that are actually used for something? it would be helpful to understand what pin 28 is used for and why we are setting it to native mode. e.g:
{SPI0_CS_N, GPIO_MODE_NATIVE, 0, 0, 0, 0}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74906bf9395a333be6250ffbd181da536e016f30
Gerrit-Change-Number: 35367
Gerrit-PatchSet: 2
Gerrit-Owner: Jingle Hsu
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
johnnylin0924@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Tue, 17 Sep 2019 20:59:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment