Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47650 )
Change subject: soc/amd/picasso: Remove unused psp_verstage spinlock.h
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Why was this abandoned (without reasoning) again?
Like I commented in fast-tracked CB:43310 there is some asymmetry with spinlock.h includes and case of CONFIG(SMP) evaluating incorrectly when stages run on different arch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47650
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bc227e20e102b715961ee09bf1a0a87bf382ecf
Gerrit-Change-Number: 47650
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kangheui Won
khwon@chromium.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 06 Feb 2021 08:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment