build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38472 )
Change subject: amd/agesa: Make BottomIo position configurable ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38472/5/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family14/state_machine.c:
https://review.coreboot.org/c/coreboot/+/38472/5/src/northbridge/amd/agesa/f... PS5, Line 51: Post->MemConfig.BottomIo = MIN(0xE0, MAX(0x28, ((UINT16)(CONFIG_BOTTOMIO_POSITION >> 24) & 0xF8))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38472/5/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/state_machine.c:
https://review.coreboot.org/c/coreboot/+/38472/5/src/northbridge/amd/agesa/f... PS5, Line 21: Post->MemConfig.BottomIo = MIN(0xE0, MAX(0x28, ((UINT16)(CONFIG_BOTTOMIO_POSITION >> 24) & 0xF8))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/38472/5/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family16kb/state_machine.c:
https://review.coreboot.org/c/coreboot/+/38472/5/src/northbridge/amd/agesa/f... PS5, Line 23: Post->MemConfig.BottomIo = MIN(0xE0, MAX(0x28, ((UINT16)(CONFIG_BOTTOMIO_POSITION >> 24) & 0xF8))); line over 96 characters