Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37604 )
Change subject: soc/intel/cannonlake: Allow Audio DSP OSC qualification for low power idle
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37604/4/src/soc/intel/cannonlake/fi...
File src/soc/intel/cannonlake/finalize.c:
https://review.coreboot.org/c/coreboot/+/37604/4/src/soc/intel/cannonlake/fi...
PS4, Line 101: /* Enable Audio DSP OSC qualification for low power idle. */
: reg32 = read32(pmcbase + CPPMVRIC2);
: reg32 &= ~ADSPOSCDIS;
: write32(pmcbase + CPPMVRIC2, reg32);
Can you fix the indentation?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20b793b95483af03ce4ae068ac07864a9e90d39b
Gerrit-Change-Number: 37604
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Grace Kao
grace.kao@intel.com
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-CC: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Comment-Date: Mon, 03 Feb 2020 23:20:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment