[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add ASL function for setting pad mode

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31444 )

Change subject: soc/intel/cannonlake: Add ASL function for setting pad mode
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31444/2/src/soc/intel/cannonlake/acpi/gpio_o... 
File src/soc/intel/cannonlake/acpi/gpio_op.asl:

https://review.coreboot.org/#/c/31444/2/src/soc/intel/cannonlake/acpi/gpio_o... 
PS2, Line 91: PADM, 2,
> We had run into this with PME status/control registers: https://review.coreboot.org/c/20364/ […]

Well, as per the specification those values should be preserved, if there is an issue that means the ACPI core in linux is not implemented as per spec. In any case will uprev with required change.