Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45571 )
Change subject: soc/intel/alderlake: Add GPIOs for Alder Lake SOC ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45571/4/src/soc/intel/alderlake/inc... File src/soc/intel/alderlake/include/soc/gpio_soc_defs.h:
https://review.coreboot.org/c/coreboot/+/45571/4/src/soc/intel/alderlake/inc... PS4, Line 310: 229
One tab too many?
Ack
https://review.coreboot.org/c/coreboot/+/45571/4/src/soc/intel/alderlake/inc... File src/soc/intel/alderlake/include/soc/pmc.h:
https://review.coreboot.org/c/coreboot/+/45571/4/src/soc/intel/alderlake/inc... PS4, Line 138: 0x9
Needs one more tab
Ack
https://review.coreboot.org/c/coreboot/+/45571/4/src/soc/intel/alderlake/inc... PS4, Line 141: 0xC
Another tab here
Ack