Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37769 )
Change subject: device/pciexp: Match Max_Payload_Size between ends of a link ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c@... PS1, Line 430: /* Set max payload to smaller of the reported device capability. */ Perhaps somewhere comment or print why you're capping the field to 5. I assume because 6 and 7 are still reserved, however I'm looking at an 8 year old copy of the spec.
https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c@... PS1, Line 448: PCIe: Max_Payload_Size adjusted to %d The console output likely makes it obvious what B:D:F this is. If not, you could maybe add that to the printk.
https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c@... PS1, Line 482: } Meh, the spec says you don't need to do this for each function in a multi-function device. Could this be conditional on PCI_FUNC(dev->Lpath.pci.devfn)) > 0?