Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot
......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc...
File util/mainboard/google/hatch/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc...
PS13, Line 24: Adds a new variant of Hatch to Kconfig and Kconfig.name, creates the"
: echo "skeleton files for acpi, ec, and gpio, copies the makefile for"
: echo "SPD sources, and sets up a basic overridetree"
I guess we need baseboard files before this.
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc...
PS13, Line 84: mkdir -p "variants/${variant}/$(dirname "${s}")"
do we need to check first if baseboard files exists or not ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35239
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a5b9c8735faafebb2e4e384cb3346867d64c556
Gerrit-Change-Number: 35239
Gerrit-PatchSet: 15
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Scott Collyer
scollyer@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
quasisec@google.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Thu, 12 Sep 2019 13:56:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment