Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38010 )
Change subject: nb/intel/sandybridge: add and use more MCHBAR register defines ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
I'll add the missing registers myself, this patch is rather buried in the train
https://review.coreboot.org/c/coreboot/+/38010/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/38010/1/src/northbridge/intel/sandy... PS1, Line 3167: 0x5880
MEM_TRML_ESTIMATION_CONFIG
Done on CB:38015
https://review.coreboot.org/c/coreboot/+/38010/1/src/northbridge/intel/sandy... PS1, Line 3168: 0x5888
MEM_TRML_THRESHOLDS_CONFIG
Done on CB:38015
https://review.coreboot.org/c/coreboot/+/38010/1/src/northbridge/intel/sandy... PS1, Line 3169: 0x58a8
MEM_TRML_CAMARILLO_INTERRUPT
Done on CB:38015