Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )
Change subject: amdfwtool: Take a config file instead of command line parameters
......................................................................
Patch Set 49:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42859/47//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42859/47//COMMIT_MSG@9
PS47, Line 9: Internal Cleanup:
shouldn't this be just "b:"?
Done. Changed.
https://review.coreboot.org/c/coreboot/+/42859/47/util/amdfwtool/amdfwtool-b...
File util/amdfwtool/amdfwtool-b.c:
PS47:
since now all platforms are updated in this patch, this copy of the old amdfwtool can be dropped fro […]
Done. Removed.
https://review.coreboot.org/c/coreboot/+/42859/47/util/amdfwtool/amdfwtool.h
File util/amdfwtool/amdfwtool.h:
https://review.coreboot.org/c/coreboot/+/42859/47/util/amdfwtool/amdfwtool.h...
PS47, Line 117: endif
#endif /* _AMD_FW_TOOL_H_ */
Done
https://review.coreboot.org/c/coreboot/+/42859/47/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/42859/47/util/amdfwtool/amdfwtool.c...
PS47, Line 169: printf("-p | --load-mp2-fw Set if load MP2 firmare\n");
Good job, build bot.
Done.Fix typo.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42859
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icae73d0730106aab687486e555ba947796e5e757
Gerrit-Change-Number: 42859
Gerrit-PatchSet: 49
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Dave Frodin
dave.frodin@se-eng.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Oct 2020 12:32:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment