Alexandru Gagniuc (mr.nuke.me@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8305
-gerrit
commit 52f0b2b401693c16503207b3875818c95388f511 Author: Alexandru Gagniuc mr.nuke.me@gmail.com Date: Thu Jan 29 22:52:39 2015 -0600
include/types.h: Provide linux-specific errno.h error codes
Although we have our own error codes, we occasionally import linux sources which use the <errno.h> codes as return values. From a maintenance standpoint it makes more sense to add such sources with minimal modifications., even if it means not using coreboot error codes. I'm also beginning to question the decision to provide subsystem-specific error codes in a generic file, but that issue will be addressed later, if needed.
Change-Id: I2333a06f53023e5babda355e69a361ef4b7df09e Signed-off-by: Alexandru Gagniuc mr.nuke.me@gmail.com --- src/include/types.h | 145 ++++++++++++++++++++++++++++++ src/southbridge/intel/i82371eb/i82371eb.h | 2 +- src/southbridge/intel/i82371eb/isa.c | 2 +- 3 files changed, 147 insertions(+), 2 deletions(-)
diff --git a/src/include/types.h b/src/include/types.h index ef5edc1..26b921e 100644 --- a/src/include/types.h +++ b/src/include/types.h @@ -31,6 +31,151 @@ * 100. */ enum cb_err { + /* + * These are error codes used by linux. Because it's not uncommon for + * us to import linux sources, it makes more sense for us to provide + * these error codes than it would to refactor such files to use + * coreboot-specific codes. We don't try to cherry-pick error codes, + * and instead we provide them all. These codes are positive as they + * are always negated before being returned. They may overlap some + * coreboot-specific codes, though that is not a concern. + */ + EPERM = 1, /* Operation not permitted */ + ENOENT = 2, /* No such file or directory */ + ESRCH = 3, /* No such process */ + EINTR = 4, /* Interrupted system call */ + EIO = 5, /* I/O error */ + ENXIO = 6, /* No such device or address */ + E2BIG = 7, /* Argument list too long */ + ENOEXEC = 8, /* Exec format error */ + EBADF = 9, /* Bad file number */ + ECHILD = 10, /* No child processes */ + EAGAIN = 11, /* Try again */ + ENOMEM = 12, /* Out of memory */ + EACCES = 13, /* Permission denied */ + EFAULT = 14, /* Bad address */ + ENOTBLK = 15, /* Block device required */ + EBUSY = 16, /* Device or resource busy */ + EEXIST = 17, /* File exists */ + EXDEV = 18, /* Cross-device link */ + ENODEV = 19, /* No such device */ + ENOTDIR = 20, /* Not a directory */ + EISDIR = 21, /* Is a directory */ + EINVAL = 22, /* Invalid argument */ + ENFILE = 23, /* File table overflow */ + EMFILE = 24, /* Too many open files */ + ENOTTY = 25, /* Not a typewriter */ + ETXTBSY = 26, /* Text file busy */ + EFBIG = 27, /* File too large */ + ENOSPC = 28, /* No space left on device */ + ESPIPE = 29, /* Illegal seek */ + EROFS = 30, /* Read-only file system */ + EMLINK = 31, /* Too many links */ + EPIPE = 32, /* Broken pipe */ + EDOM = 33, /* Math argument out of domain of func */ + ERANGE = 34, /* Math result not representable */ + EDEADLK = 35, /* Resource deadlock would occur */ + ENAMETOOLONG = 36, /* File name too long */ + ENOLCK = 37, /* No record locks available */ + ENOSYS = 38, /* Function not implemented */ + ENOTEMPTY = 39, /* Directory not empty */ + ELOOP = 40, /* Too many symbolic links encountered */ + EWOULDBLOCK = EAGAIN, /* Operation would block */ + ENOMSG = 42, /* No message of desired type */ + EIDRM = 43, /* Identifier removed */ + ECHRNG = 44, /* Channel number out of range */ + EL2NSYNC = 45, /* Level 2 not synchronized */ + EL3HLT = 46, /* Level 3 halted */ + EL3RST = 47, /* Level 3 reset */ + ELNRNG = 48, /* Link number out of range */ + EUNATCH = 49, /* Protocol driver not attached */ + ENOCSI = 50, /* No CSI structure available */ + EL2HLT = 51, /* Level 2 halted */ + EBADE = 52, /* Invalid exchange */ + EBADR = 53, /* Invalid request descriptor */ + EXFULL = 54, /* Exchange full */ + ENOANO = 55, /* No anode */ + EBADRQC = 56, /* Invalid request code */ + EBADSLT = 57, /* Invalid slot */ + EDEADLOCK = EDEADLK, + EBFONT = 59, /* Bad font file format */ + ENOSTR = 60, /* Device not a stream */ + ENODATA = 61, /* No data available */ + ETIME = 62, /* Timer expired */ + ENOSR = 63, /* Out of streams resources */ + ENONET = 64, /* Machine is not on the network */ + ENOPKG = 65, /* Package not installed */ + EREMOTE = 66, /* Object is remote */ + ENOLINK = 67, /* Link has been severed */ + EADV = 68, /* Advertise error */ + ESRMNT = 69, /* Srmount error */ + ECOMM = 70, /* Communication error on send */ + EPROTO = 71, /* Protocol error */ + EMULTIHOP = 72, /* Multihop attempted */ + EDOTDOT = 73, /* RFS specific error */ + EBADMSG = 74, /* Not a data message */ + EOVERFLOW = 75, /* Value too large for defined data type */ + ENOTUNIQ = 76, /* Name not unique on network */ + EBADFD = 77, /* File descriptor in bad state */ + EREMCHG = 78, /* Remote address changed */ + ELIBACC = 79, /* Can not access a needed shared library */ + ELIBBAD = 80, /* Accessing a corrupted shared library */ + ELIBSCN = 81, /* .lib section in a.out corrupted */ + ELIBMAX = 82, /* Attempting to link in too many shared libraries */ + ELIBEXEC = 83, /* Cannot exec a shared library directly */ + EILSEQ = 84, /* Illegal byte sequence */ + ERESTART = 85, /* Interrupted system call should be restarted */ + ESTRPIPE = 86, /* Streams pipe error */ + EUSERS = 87, /* Too many users */ + ENOTSOCK = 88, /* Socket operation on non-socket */ + EDESTADDRREQ = 89, /* Destination address required */ + EMSGSIZE = 90, /* Message too long */ + EPROTOTYPE = 91, /* Protocol wrong type for socket */ + ENOPROTOOPT = 92, /* Protocol not available */ + EPROTONOSUPPORT = 93, /* Protocol not supported */ + ESOCKTNOSUPPORT = 94, /* Socket type not supported */ + EOPNOTSUPP = 95, /* Operation not supported on transport endpoint */ + EPFNOSUPPORT = 96, /* Protocol family not supported */ + EAFNOSUPPORT = 97, /* Address family not supported by protocol */ + EADDRINUSE = 98, /* Address already in use */ + EADDRNOTAVAIL = 99, /* Cannot assign requested address */ + ENETDOWN = 100, /* Network is down */ + ENETUNREACH = 101, /* Network is unreachable */ + ENETRESET = 102, /* Network dropped connection because of reset */ + ECONNABORTED = 103, /* Software caused connection abort */ + ECONNRESET = 104, /* Connection reset by peer */ + ENOBUFS = 105, /* No buffer space available */ + EISCONN = 106, /* Transport endpoint is already connected */ + ENOTCONN = 107, /* Transport endpoint is not connected */ + ESHUTDOWN = 108, /* Cannot send after transport endpoint shutdown */ + ETOOMANYREFS = 109, /* Too many references: cannot splice */ + ETIMEDOUT = 110, /* Connection timed out */ + ECONNREFUSED = 111, /* Connection refused */ + EHOSTDOWN = 112, /* Host is down */ + EHOSTUNREACH = 113, /* No route to host */ + EALREADY = 114, /* Operation already in progress */ + EINPROGRESS = 115, /* Operation now in progress */ + ESTALE = 116, /* Stale file handle */ + EUCLEAN = 117, /* Structure needs cleaning */ + ENOTNAM = 118, /* Not a XENIX named type file */ + ENAVAIL = 119, /* No XENIX semaphores available */ + EISNAM = 120, /* Is a named type file */ + EREMOTEIO = 121, /* Remote I/O error */ + EDQUOT = 122, /* Quota exceeded */ + ENOMEDIUM = 123, /* No medium found */ + EMEDIUMTYPE = 124, /* Wrong medium type */ + ECANCELED = 125, /* Operation Canceled */ + ENOKEY = 126, /* Required key not available */ + EKEYEXPIRED = 127, /* Key has expired */ + EKEYREVOKED = 128, /* Key has been revoked */ + EKEYREJECTED = 129, /* Key was rejected by service */ + /* for robust mutexes */ + EOWNERDEAD = 130, /* Owner died */ + ENOTRECOVERABLE = 131, /* State not recoverable */ + ERFKILL = 132, /* Operation not possible due to RF-kill */ + EHWPOISON = 133, /* Memory page has hardware error */ + + /* Generic coreboot error codes */ CB_SUCCESS = 0, /**< Call completed succesfully */ CB_ERR = -1, /**< Generic error code */ CB_ERR_ARG = -2, /**< Invalid argument */ diff --git a/src/southbridge/intel/i82371eb/i82371eb.h b/src/southbridge/intel/i82371eb/i82371eb.h index f16d817..495587b 100644 --- a/src/southbridge/intel/i82371eb/i82371eb.h +++ b/src/southbridge/intel/i82371eb/i82371eb.h @@ -129,7 +129,7 @@ void enable_pm(void); #define SSDE0 (1 << 2) /* Secondary Drive 0 UDMA/33 */ #define SSDE1 (1 << 3) /* Secondary Drive 1 UDMA/33 */ #define ISA (1 << 0) /* Select ISA */ -#define EIO (0 << 0) /* Select EIO */ +#define EXTENDED_IO (0 << 0) /* Select EIO */ #define PMIOSE (1 << 0) /* PM I/O Space Enable */
#endif /* SOUTHBRIDGE_INTEL_I82371EB_I82371EB_H */ diff --git a/src/southbridge/intel/i82371eb/isa.c b/src/southbridge/intel/i82371eb/isa.c index 1deddf6..28b65b8 100644 --- a/src/southbridge/intel/i82371eb/isa.c +++ b/src/southbridge/intel/i82371eb/isa.c @@ -82,7 +82,7 @@ static void isa_init(struct device *dev) * bus, which is a subset of ISA. We select the full ISA bus here. */ reg32 = pci_read_config32(dev, GENCFG); - reg32 |= ISA; /* Select ISA, not EIO. */ + reg32 |= ISA; /* Select ISA, not EXTENDED_IO. */ pci_write_config16(dev, GENCFG, reg32);
/* Initialize ISA DMA. */