Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48305 )
Change subject: soc/amd: factor out common family 17h&19h TSC and monotonic timer code
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48305/1/src/soc/amd/common/block/ts...
File src/soc/amd/common/block/tsc/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48305/1/src/soc/amd/common/block/ts...
PS1, Line 7:
there is currently no guard for that and i don't think that we should add clutter to coreboot-common […]
Good point on verstage on psp.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29cfef5d8920c29e36c55fc46a90eb579a042b64
Gerrit-Change-Number: 48305
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 05 Dec 2020 15:47:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment