10 Nov
2020
10 Nov
'20
2:34 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47023 )
Change subject: sb/intel/common: Add AHCI library ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47023/3/src/southbridge/intel/commo... File src/southbridge/intel/common/ahci.h:
https://review.coreboot.org/c/coreboot/+/47023/3/src/southbridge/intel/commo... PS3, Line 32: /* Note that this port register (0x1c + _AHCI_PORT_OFFSET(x)) is not in the AHCI spec */
why add it (even as comment) when it's not there?
I didn't notice it was missing at first, and since the other registers are contiguous, I placed this comment to fill in the gap.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47023
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffca4533f418340462fc773c2432e30a5abed6ac
Gerrit-Change-Number: 47023
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Nov 2020 12:34:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment