HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33033 )
Change subject: [WIP] ssdtgen for PNP devices ......................................................................
Patch Set 16:
(5 comments)
https://review.coreboot.org/c/coreboot/+/33033/16/src/superio/common/ssdt.c File src/superio/common/ssdt.c:
https://review.coreboot.org/c/coreboot/+/33033/16/src/superio/common/ssdt.c@... PS16, Line 17: include <superio/common/chip.h> : #include <superio/common/ssdt.h> : : #include <device/device.h> : #include <device/pnp.h> : #include <arch/acpigen.h> : #include <device/pnp_def.h> : #include <console/console.h> to sort
https://review.coreboot.org/c/coreboot/+/33033/16/src/superio/common/ssdt.c@... PS16, Line 25: missing include <types.h>
https://review.coreboot.org/c/coreboot/+/33033/16/src/superio/common/ssdt.c@... PS16, Line 54: printk(BIOS_ERR, "%s: Missing ACPI path/scope\n", : dev_path(dev)); on one line ?
https://review.coreboot.org/c/coreboot/+/33033/16/src/superio/common/ssdt.c@... PS16, Line 69: struct opregion opreg = OPREGION("IOID", SYSTEMIO, : dev->path.pnp.port, 2); one line
https://review.coreboot.org/c/coreboot/+/33033/16/src/superio/common/ssdt.c@... PS16, Line 324: printk(BIOS_WARNING, "%s: No HID set in devicetree\n", : dev_path(dev)); one line