[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Add display controller driver

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )

Change subject: mediatek/mt8183: Add display controller driver
......................................................................

Patch Set 20:

(3 comments)

https://review.coreboot.org/c/coreboot/+/31478/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/31478/8//COMMIT_MSG@9 
PS8, Line 9: BUG
> Please add more information in the description. […]

Ack

https://review.coreboot.org/c/coreboot/+/31478/11/src/soc/mediatek/mt8183/in... 
File src/soc/mediatek/mt8183/include/soc/ddp.h:

https://review.coreboot.org/c/coreboot/+/31478/11/src/soc/mediatek/mt8183/in... 
PS11, Line 4: 2015
> 2019

Ack

https://review.coreboot.org/c/coreboot/+/31478/11/src/soc/mediatek/mt8183/in... 
PS11, Line 58: /* DISP_REG_CONFIG_MMSYS_CG_CON0
             :    Configures free-run clock gating 0
             : 	0: Enable clock
             : 	1: Clock gating  */
> /* […]

Ack