Attention is currently required from: Martin L Roth, Jon Murphy, Angel Pons, Karthik Ramasubramanian, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74736 )
Change subject: util/sconfig: Include optional maiboard chip header
......................................................................
Patch Set 7:
(1 comment)
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/74736/comment/c59e154f_8415fd11
PS7, Line 2016: get_chip
Well, there's already some sort of "mainboard chip" somewhere. At least, `mainboard.c` (e.g. where applicable) has a `struct chip_operations mainboard_ops`.
That would be the root device and it's guaranteed only one device that uses it. ;-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74736
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34893a703cc4f588dda3736e858429bf765059e6
Gerrit-Change-Number: 74736
Gerrit-PatchSet: 7
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 10 May 2023 14:38:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment