Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35018 )
Change subject: soc/amd/common/block: Create new SPI code
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35018/1/src/soc/amd/common/block/sp...
File src/soc/amd/common/block/spi/fch_spi_ctrl.c:
https://review.coreboot.org/c/coreboot/+/35018/1/src/soc/amd/common/block/sp...
PS1, Line 171: static int amd_xfer_vectors( struct spi_op vectors[], size_t count)
space prohibited after that open parenthesis '('
Done
https://review.coreboot.org/c/coreboot/+/35018/1/src/soc/amd/common/block/sp...
PS1, Line 274: int (*probe) (const struct spi_slave *spi, u8 *idcode,
Unnecessary space before function pointer arguments
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35018
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id293fb9b2da84c4206c7a1341b64e83fc0b8d71d
Gerrit-Change-Number: 35018
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Aug 2019 19:30:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment