Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35605 )
Change subject: util/mb/google/hatch: add optional bug parameter, fix style issues
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35605/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35605/1//COMMIT_MSG@7
PS1, Line 7: util/mb/google/hatch: add optional bug parameter, fix style issues
Could you split the commit?
https://review.coreboot.org/c/coreboot/+/35605/1//COMMIT_MSG@7
PS1, Line 7: util
It’s not clear, that it’s about the script.
https://review.coreboot.org/c/coreboot/+/35605/1//COMMIT_MSG@14
PS1, Line 14:
Your Signed-off-by line is missing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35605
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63aa0aa633f36b9543e809fc42fac955da5960a3
Gerrit-Change-Number: 35605
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Andrew McRae
amcrae@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Sep 2019 15:48:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment