David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34686 ) Change subject: baytrail/rangeley: Update paths for FSP_FILE and VGA_BIOS_BIN ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/34686/2/src/soc/intel/fsp_baytrail/... File src/soc/intel/fsp_baytrail/Kconfig: https://review.coreboot.org/c/coreboot/+/34686/2/src/soc/intel/fsp_baytrail/... PS2, Line 104:
Though I have known to this path doesn't point it out before as these headers doesn't work for me (m […] Yeah, the headers are a bit weird. I had issues a couple years ago too: https://mail.coreboot.org/pipermail/coreboot/2017-August/084837.html
You are correct that there is a microcode binary in 3rdparty/blobs/soc/intel/baytrail/ but line 48 of this Kconfig file shows that headers are selected by default (select USES_MICROCODE_HEADER_FILES if HAVE_FSP_BIN). -- To view, visit https://review.coreboot.org/c/coreboot/+/34686 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35b0b08a13ad2deeb3e2efa146ab1916d5d23a14 Gerrit-Change-Number: 34686 Gerrit-PatchSet: 5 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: David Guckian <david.guckian@intel.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Huang Jin <huang.jin@intel.com> Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 06 Aug 2019 15:57:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Name of user not set #1002476 Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com> Gerrit-MessageType: comment