Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43133 )
Change subject: baytrail RFC: native replacement for refcode.elf ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43133/3/src/soc/intel/baytrail/modp... File src/soc/intel/baytrail/modphy_table.c:
PS3:
This table should make use of the existing IOSF infrastructure in coreboot. […]
The first column is the IOSF-SB port (8-bit value), the second value is the offset (not sure of its size), the third column is an and-mask, the fourth one is the or-value and the last two columns are read and write opcodes (which only depend on the IOSF-SB port being accessed). I'd define a struct:
struct baytrail_modphy_entry { uint8_t port; uint32_t offset; /* or uint16_t, need to check */ uint32_t mask; uint32_t or; };
And then determine the opcodes depending on the IOSF port.