Attention is currently required from: Jérémy Compostella.
Hello Jérémy Compostella, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79827?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: arch/x86/include/smm: use inline asm from drivers/smmstore/ramstage ......................................................................
arch/x86/include/smm: use inline asm from drivers/smmstore/ramstage
The call_smm function is currently unused and the inline assembly code for more or less the same functionality in drivers/smmstore/ramstage is both a bit easier to understand since it uses the register names in the 'outb' instruction instead of positional arguments, and also tells the compiler that this piece of code might change global memory. Having too much in the clobber list might only have some performance impact, which should however be negligible compared to the SMI handler being called, while missing something in the clobber list might cause hard to debug problems.
This is a preparation to make drivers/smmstore/ramstage use call_smm instead of having its own inline assembly implementation for this.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I73837cab75429014897486b38a5c56f93a850f96 --- M src/arch/x86/include/smm.h 1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/79827/2