Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45270 )
Change subject: xeon_sp: Update skx ITSS OperationRegion to ACPI2.0 notation ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a... File src/soc/intel/xeon_sp/skx/acpi/pci_irq.asl:
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 61: Store
sure
I've updated the summary to correctly describe the change. I didn't update the entire file, just the most complicated OperationRegion statement. This will make a merge the cpx ASL easier.
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 64: ShiftLeft
same
Ack
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 71: Decrement (Local0) \ : Store
also this
Ack
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 76: And
old acpi
Ack
https://review.coreboot.org/c/coreboot/+/45270/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 84: Or
can this be converted to acpi2 notation ?
Ack