Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40806 )
Change subject: sb/amd/cimx/sb800: Fix 16-bit read/write PCI_COMMAND register
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40806/1/src/southbridge/amd/cimx/sb...
File src/southbridge/amd/cimx/sb800/late.c:
https://review.coreboot.org/c/coreboot/+/40806/1/src/southbridge/amd/cimx/sb...
PS1, Line 102: pci_write_config16(dev, PCI_COMMAND, dev->command);
Thank you so much. […]
As per some IRC talk, looks like dev->command is only 8 bits wide. So this is wrong.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40806
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I779387fb0c9d3ad6e16d4ccfc39c38dfe6620345
Gerrit-Change-Number: 40806
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 07 Jun 2020 15:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment