Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45174 )
Change subject: nb/intel/ironlake/raminit: Work around compiler bug ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45174/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45174/1//COMMIT_MSG@7 PS1, Line 7: nb/intel/ironlake/raminit: Fix compiler bug
I would say "Work around" not fix.
Done
https://review.coreboot.org/c/coreboot/+/45174/1//COMMIT_MSG@9 PS1, Line 9: This fixes e1d1fe454cf27d6b1c2ef5625f1cefc1a9c6ec9d
Please add *commit* before the hash, so Gerrit converts it to a link.
Done
https://review.coreboot.org/c/coreboot/+/45174/1//COMMIT_MSG@13 PS1, Line 13: a binary that always calls die().
Mention the condition, so one does not have to look for it?
Done
https://review.coreboot.org/c/coreboot/+/45174/1/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/45174/1/src/northbridge/intel/ironl... PS1, Line 1803: (u32 *)
This cast might be causing problems
Ack