Attention is currently required from: Shaunak Saha, Furquan Shaikh, Martin Roth, Angel Pons, Subrata Banik, Michael Niewöhner, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51649 )
Change subject: soc/intel/tgl,mb/google/volteer: Add API for Type-C aux bias pads ......................................................................
Patch Set 19:
(6 comments)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/51649/comment/44f5830a_edf0519e PS18, Line 324: soc_tcss_configure_aux_bias_pads
Yeah, this is slightly awkward, isn't it... […]
Ack
File src/soc/intel/tigerlake/tcss.c:
https://review.coreboot.org/c/coreboot/+/51649/comment/62e0e7e3_0a74a683 PS18, Line 16: 0xb7
Use macros for these at the start of the file?
Done
https://review.coreboot.org/c/coreboot/+/51649/comment/30e8e58a_6d2f049e PS18, Line 23: default:
Print an error that we encountered an unknown GPIO PID?
Done
https://review.coreboot.org/c/coreboot/+/51649/comment/39838e14_b9938330 PS18, Line 71: pad_index = (pad_index + 4) % 8;
No, this was just the way the table was structured, all H pads were offset by 4 😞
Ack
https://review.coreboot.org/c/coreboot/+/51649/comment/0cec74ee_d231354e PS18, Line 81: 16
Use macros for the bit shifts.
Done
https://review.coreboot.org/c/coreboot/+/51649/comment/f7405980_d1cfb2e1 PS18, Line 90: soc_tcss_configure_aux_bias_pads
I think this callback is okay for now to make progress. […]
See compromise in new patchtrain