shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34581 )
Change subject: mb/google/kohaku: Enable stylus pen device
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34581/5/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34581/5/src/mainboard/google/hatch/...
PS5, Line 89: reset_gpio
If you are planning to add reset gpio to power resource, then it does not need to be set to 1 in gpi […]
We cannot use GPP_A10 as reset_gpio (b/137326841#comment86) so need further discussion.
How about remove reset_gpio right now? Or we can hold this CL until we get decision about this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic252a1f90c0fc6cb9b1e426d75a8b503824681f3
Gerrit-Change-Number: 34581
Gerrit-PatchSet: 6
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: shkim
sh_.kim@samsung.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philip Chen
philipchen@google.com
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Comment-Date: Wed, 07 Aug 2019 01:08:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment