KOUAM Ledoux has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43756 )
Change subject: src:cast all void *cbmem_top_chipset() function to uintptr_t ......................................................................
Patch Set 15: Code-Review+1
(7 comments)
Patch Set 1:
(3 comments)
it needs manual rebase you also need to touch "src/include/cbmem.h" file.
will you also change returned value of cbmem_top(void) to uinptr_t in a separate patch ?
Everything is up to date
https://review.coreboot.org/c/coreboot/+/43756/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43756/1//COMMIT_MSG@7 PS1, Line 7: cast all void *cbmem_top_chipset() function to uintptr_t
src: cast all void *cbmem_top_chipset() function to uintptr_t
Done
https://review.coreboot.org/c/coreboot/+/43756/1//COMMIT_MSG@9 PS1, Line 9: Cast all cbmem_top_chipset to uintptr_t
Why? What for? It would be nice to explain that in the commit message.
Done
https://review.coreboot.org/c/coreboot/+/43756/1//COMMIT_MSG@12 PS1, Line 12: root
? :)
Done
https://review.coreboot.org/c/coreboot/+/43756/1/src/acpi/acpi.c File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/43756/1/src/acpi/acpi.c@510 PS1, Line 510: int acpi_create_srat_lx2apic(acpi_srat_lx2apic_t *lx2apic, u8 node, u8 x2apic)
This doesn't belong to this patch
Done
https://review.coreboot.org/c/coreboot/+/43756/1/src/arch/x86/cbmem.c File src/arch/x86/cbmem.c:
https://review.coreboot.org/c/coreboot/+/43756/1/src/arch/x86/cbmem.c@1 PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ : : #include <cbmem.h> : #include <stdint.h> : : #if CONFIG(CBMEM_TOP_BACKUP) : : uintptr_t cbmem_top_chipset(void) : { : /* Top of CBMEM is at highest usable DRAM address below 4GiB. */ : return (uintptr_t)(restore_top_of_low_cacheable()); : } : : #endif /* CBMEM_TOP_BACKUP */
this file is removed […]
Done
https://review.coreboot.org/c/coreboot/+/43756/1/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/43756/1/src/include/acpi/acpi.h@238 PS1, Line 238: /* SRAT: x2APIC Affinity Structure */
This doesn't belong to this patch
Done
https://review.coreboot.org/c/coreboot/+/43756/1/src/include/acpi/acpi.h@952 PS1, Line 952: int acpi_create_srat_lx2apic(acpi_srat_lx2apic_t *lx2apic, u8 node, u8 x2apic);
This doesn't belong to this patch
Done