[coreboot-gerrit] [L] Change in coreboot[master]: util/amdfwtool: Deal with psp position in flash offset directly

[Arthur Heymans (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth, Fred Reitberger, Karthik Ramasubramanian, Felix Held.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69852 )

Change subject: util/amdfwtool: Deal with psp position in flash offset directly
......................................................................

Patch Set 4:

(1 comment)

File src/soc/amd/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/69852/comment/3faa1d99_cab8e6d3 
PS4, Line 25: $(call int-subtract, 0xffffffff $(CONFIG_ROM_SIZE)) 1 $(CONFIG_AMD_FWM_POSITION))
> This will lead to integer overflow if CONFIG_AMD_FWM_POSITION is greater than ROM_SIZE.
>
> eg. Mandolin has 8 MB ROM size but AMD_FWM_POSITION is 0xc20000

I guess the position for mandolin is just wrong then.