build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32529 )
Change subject: SKL: add ACPI brightness control ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/acpi.c File src/soc/intel/skylake/acpi.c:
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/acpi.c@891 PS1, Line 891: for (i = 0; i < conf->ndid; i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/acpi.c@892 PS1, Line 892: acpigen_write_dword (conf->did[i]); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/acpi.c@903 PS1, Line 903: if (!strcmp(names[i],"LCD")) { space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/acpi.c@904 PS1, Line 904: printk(BIOS_ERR,"generate ACPI methods for LCD\n"); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/graphics.c File src/soc/intel/skylake/graphics.c:
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/graphics.c@129 PS1, Line 129: struct device *dev = dev_find_slot(0, PCI_DEVFN(0x2,0)); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/graphics.c@130 PS1, Line 130: if (!dev) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/graphics.c@141 PS1, Line 141: if (!gfx) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/graphics.c@145 PS1, Line 145: } adding a line without newline at end of file
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/include/soc/i9... File src/soc/intel/skylake/include/soc/i915.h:
https://review.coreboot.org/#/c/32529/1/src/soc/intel/skylake/include/soc/i9... PS1, Line 23: { open brace '{' following struct go on the same line