[coreboot-gerrit] Change in coreboot[master]: device: Add checks for NULL in device_const.c functions

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40475 )

Change subject: device: Add checks for NULL in device_const.c functions
......................................................................

Patch Set 5:
> Patch Set 3:
> > > Shouldn't we use assertions instead? I can imagine any case where
> > > it would be valid call these functions with NULL.
> >
> > Sure, I can add assert() or in fact die() since assert() might not be fatal.
>
> IIRC, the weird argument to allow non-fatal assertions was that somebody
> might favor unreliable firmware over failing firmware. If we now work
> around this by using die() directly instead of assertions, I fear we
> only push these people to implement non-fatal die().

Okay. I changed it back to assert.