Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45014 )
Change subject: soc/intel/tigerlake: Update TCSS PM flow
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45014/3/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/45014/3/src/soc/intel/tigerlake/acp...
PS3, Line 622: 2
Is '2' (or '3' above) just for debugging? Because the _PS0 method only cares if SCMP is 1, so why not just set it back to 0 here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45014
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebc8065fe4c8600960d089577608890ab12a95fc
Gerrit-Change-Number: 45014
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Sep 2020 19:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment